feat: granular per-mode alert filters (v0.9.3)
Replace coarse milestone/referral suppression with 8 named action categories (vote, presidential, committee_report, calendar, procedural, referral, new_document, new_amendment), each independently togglable per follow mode (Follow / Pocket Veto / Pocket Boost). - notification_utils: categorize_action() replaces is_milestone_action / is_referral_action; _build_payload stores action_category in payload - congress_poller: use categorize_action() in _update_bill_if_changed - notification_dispatcher: _should_dispatch() checks per-mode filter dict from notification_prefs; follow mode looked up before filter check - schemas + api: alert_filters (nested dict) wired through settings GET/PUT endpoints; no DB migration required - frontend: tabbed Alert Filters section (Follow / Pocket Veto / Pocket Boost), each with independent 8-toggle filter set, milestone parent checkbox (indeterminate-aware), Load defaults button, and per-tab Save button Authored-By: Jack Levy
This commit is contained in:
@@ -45,6 +45,32 @@ _EVENT_PRIORITY = {
|
||||
}
|
||||
|
||||
|
||||
_FILTER_DEFAULTS = {
|
||||
"new_document": False, "new_amendment": False, "vote": False,
|
||||
"presidential": False, "committee_report": False, "calendar": False,
|
||||
"procedural": False, "referral": False,
|
||||
}
|
||||
|
||||
|
||||
def _should_dispatch(event, prefs: dict, follow_mode: str = "neutral") -> bool:
|
||||
payload = event.payload or {}
|
||||
|
||||
# Map event type directly for document events
|
||||
if event.event_type == "new_document":
|
||||
key = "new_document"
|
||||
elif event.event_type == "new_amendment":
|
||||
key = "new_amendment"
|
||||
else:
|
||||
# Use action_category if present (new events), fall back from milestone_tier (old events)
|
||||
key = payload.get("action_category")
|
||||
if not key:
|
||||
key = "referral" if payload.get("milestone_tier") == "referral" else "vote"
|
||||
|
||||
all_filters = prefs.get("alert_filters") or {}
|
||||
mode_filters = all_filters.get(follow_mode) or {}
|
||||
return bool(mode_filters.get(key, _FILTER_DEFAULTS.get(key, True)))
|
||||
|
||||
|
||||
def _in_quiet_hours(prefs: dict, now: datetime) -> bool:
|
||||
"""Return True if the current local time falls within the user's quiet window.
|
||||
|
||||
@@ -104,23 +130,12 @@ def dispatch_notifications(self):
|
||||
).first()
|
||||
follow_mode = follow.follow_mode if follow else "neutral"
|
||||
|
||||
# Pocket Veto: only milestone (bill_updated) events; skip LLM brief events
|
||||
if follow_mode == "pocket_veto" and event.event_type in ("new_document", "new_amendment"):
|
||||
event.dispatched_at = now
|
||||
db.commit()
|
||||
continue
|
||||
|
||||
# Referral-tier events (committee referrals) are noisy for loose topic follows;
|
||||
# suppress them only for topic-follow events so direct bill/member followers
|
||||
# still get notified when their bill is referred to committee.
|
||||
payload = event.payload or {}
|
||||
is_topic_follow = payload.get("source") == "topic_follow"
|
||||
if follow_mode == "neutral" and payload.get("milestone_tier") == "referral" and is_topic_follow:
|
||||
event.dispatched_at = now
|
||||
db.commit()
|
||||
continue
|
||||
|
||||
prefs = user.notification_prefs or {}
|
||||
|
||||
if not _should_dispatch(event, prefs, follow_mode):
|
||||
event.dispatched_at = now
|
||||
db.commit()
|
||||
continue
|
||||
ntfy_url = prefs.get("ntfy_topic_url", "").strip()
|
||||
ntfy_auth_method = prefs.get("ntfy_auth_method", "none")
|
||||
ntfy_token = prefs.get("ntfy_token", "").strip()
|
||||
|
||||
Reference in New Issue
Block a user